Jakub T. Jankiewicz

Results 1194 comments of Jakub T. Jankiewicz
trafficstars

This is only required by hot reload, so the fix was to add `id` option that replace old terminal with the same data in Cycle data structure. With a single...

This is a race condition, this works fine: ```javascript term.clear(); term.echo(async () => `this is async function`); setTimeout(() => { const view = term.export_view(); term.clear(); term.import_view(view); }); ``` Not sure...

This is more problematic, the solution above only works when the async function does nothing. The export view needs to happen after the function is resolved.

To not break the API, the export_view is still synchronous. I've added `terminal::view_ready()` that allow to wait for all async functions to finish.

No. I didn't even realize that experimental `define-library` is part of the code. I was reading the code, it was not working but found a bug. You need to update...

I'm not sure if this best approach, but if it pass all the tests and if you add additional tests that make sure that all edge cases are handled, like...

Maybe this video about implementation of useState hook from scratch will be useful: * [Can Swyx recreate React Hooks and useState in under 30 min? - JSConf.Asia](https://www.youtube.com/watch?v=KJP1E-Y-xyo)

Maybe it will be good idea to keep top level exit only when login is used. But for nested interpreters it should be defined. Maybe even remove this error message...

Thanks for the PR, unfortunately I'm not able to merge because test are failing, and I don't know how to fix them.

I tried to push to force re-run the tests. But it seems that you didn't allow edits to your PR.