Jakub T. Jankiewicz

Results 1207 comments of Jakub T. Jankiewicz

Maybe your memfs is not compatible with Node.js which is a requirement of isomorphic-git. Here is an example of MemoryFS using LightingFS, that I created for one of my projects....

Did you install the library with `npm intall figlet`? Please create minimal reproduction so it can be tested and debugged, if this is really an issue with this library.

Instead of fixed 14 we can use another CSS variable: ```css :root { --size: 1.2; --terminal-rows: 14; } .terminal { height: calc((var(--terminal-line) * var(--terminal-rows)) + 20px); } ```

And we can also parametrize the padding. ```css :root { --terminal-padding: 10px; } .terminal { height: calc((var(--terminal-line) * var(--terminal-rows)) + (var(--terminal-padding) * 2)); }

`--padding` already exists. Here is a demo: https://codepen.io/jcubic/pen/PorzvVd?editors=0100

Unfortunately, it's not possible to add `--cols` custom property because of the scrollbar. This doesn't work: ```css width: calc((var(--cols) * 1ch) + (var(--padding, 10) * 2px)) !important; ```

Example: https://codepen.io/jcubic/pen/ExBGKbV

Added experimental `--cols`, the scrollbar width is calculated in JavaScript. But there is a bug in a away Chromium is calculating of characters per line: [Wrong calculation of ch units...

This sounds like bug, if fetch fail to get the font it should call next() with an error.

You've broken all tests that use the function you modified.