Jakub T. Jankiewicz

Results 1293 comments of Jakub T. Jankiewicz

I'm unsure how to fix it, would you like to take a look, figure that out, and help by creating a PR?

You don't need to keep a map with keys, there is [key property](https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key) on the event object. The current code don't use it but you can change it.

I would add: ```javascript var key = event.key.toUpperCase(); ``` to make sure that the name of the key is correct. Also you need to update this line: ```javascript nativeInputValueSetter.call(this._input, this._tags.join(','));...

No, delimiter is not when a specific key is pressed, the issue was about input element. Delimiter is something in between, like `foo,bar,baz`.

Please read the issue you're closing: > Currently the library only allows comma as delimiter. It would be great to have an option to set the delimiter (for instance semi-colon)...

Closing, since this implements something totally different that it should.

Do you want to contribute and implement this? I'm afraid if you will not do this yourself or find someone that will do this, this will never be implemented. This...

Sorry I have no idea.

Yes, this is a problem with Emscripten. I've even created an issue after someone asked a question on StackOverflow https://github.com/emscripten-core/emscripten/issues/6115 it seems there is Asyncify now, but I'm not sure...

I think it better to keep the option but use default value, just in case it need to be updated.