Joshua C. Colp comments

Results 223 comments of


                                            Joshua C. Colp

trafficstars

[improvement]: Document EXTEN can include options/parameters for PJSIP

So you are saying the documentation about that option should be extended to also mention that it covers EXTEN?

[improvement]: Document EXTEN can include options/parameters for PJSIP

What documentation and wording regarding EXTEN?

app_queue: Allow queue strategy to be manipulated externally.

And it would be associated to queues and callers... how? My requirement still stands regardless.

[bug]: sorcery cache remove stale object if backend return error OR timeout.

The project can not take patches from other repos and include them or look at them. Contributions need to be done as a pull request with a contributor license agreement.

[new-feature]: Allow wildcard CN's in TLS certs for SIP

Inline patches are not accepted. All patches need to go through a PR request with a contributor license agreement signed. If you want to maintain such a patch yourself it...

[new-feature]: Allow wildcard CN's in TLS certs for SIP

@dirkx Do you plan on going through the code contribution process for this?

format_lame: MP3 read and write with LAME library.

To follow up on licensing this can be included.

[bug]: chan_pjsip uses wrong IP in SIP messages if at least two ip addresses are configured

I assume you are referring to SIP messages using PJSIP. What is the transport configuration? Additionally, res_hep is community supported.

format_mp3: Add MP3 write support.

I agree with Sean, and what is the license for lame?

format_mp3: Add MP3 write support.

Both existing, if lame is available then full support, if not available then nothing changes.