Joshua C. Colp comments

Results 223 comments of


                                            Joshua C. Colp

trafficstars

core,app_dial,pjsip: Implement Advanced Codec Negotiation (ACN)

I'm sticking to the policy that breaking changes are for standard releases, which next would be 23. If this change can be altered to maintain backwards compatibility then it would...

core,app_dial,pjsip: Implement Advanced Codec Negotiation (ACN)

I've converted it to a draft.

core,app_dial,pjsip: Implement Advanced Codec Negotiation (ACN)

I've added it.

[bug]: Cannot transfer call in TLS setup with SRTP, SDES - call terminated when pressing transfer key on phone

Please provide the COMPLETE PJSIP configuration, including endpoint configuration. We also need a debug level log: https://docs.asterisk.org/Operation/Logging/Collecting-Debug-Information/?h=collecting It's also important to attach these things, and not link to outside resources...

config.c: Make ast_variable_retrieve return last match.

Once 21 was branched breaking changes went off the table unless absolutely necessary for some reason. The cut off point is when it is branched, not when the first release...

config.c: Make ast_variable_retrieve return last match.

Correct.

config.c: Make ast_variable_retrieve return last match.

Unless it was done in an optional manner that defaults to maintaining existing behavior.

config.c: Make ast_variable_retrieve return last match.

Label created and added.

res_pjsip_device_features: Add forwarding and DND synchronization.

I also agree with Alexei's comments

channels: Avoid deadlocks when locking ao2_container *channels

Due to the last comment I am transitioning this to a draft as it does not appear to be in a state for review as it does not resolve the...