Joshua C. Colp

Results 223 comments of Joshua C. Colp
trafficstars

> This could clobber an existing variable. Maybe it should be master only? Ooh, excellent point I hadn't considered. That or turning it into a dialplan function which can pull...

> > Should be a UserNote (new feature) not UpgradeNote (possible breaking change). > > It was requested this be master only because it "could" be breaking, that's why I...

I agree regarding not using dialplan variables. Older things use dialplan variables because at the time there was no other way. For inclusion I will require it to be a...

When did I actually approve this... why... *looks back*

Oh, I never unapproved when we had our discussion. That explains it. I'm reverting this and reopening.

I haven't looked at the code, just the upgrade note, but the options can not be removed. They must continue to exist.

Yes. We can not remove options in minor versions, or alter their behavior, unless there is a critical reason why - such as a security issue. This does not rise...

For example, if the options are kept but default to empty in the code we can determine that they are actually unset. Default behavior should remain the same in that...

Asterisk 21, once branched, can no longer receive breaking changes.