Joshua C Elliott

Calling log.Close() more than once will cause a panic with: ``` runtime error: close of closed channel ``` The close method should be safe to call multiple times.

ARM Support

9

I know goluago does not advertise ARM support yet, but how much work would it be to add it? Currently, compiling a go program that imports goluago on ARM gives...

Authentication documentation discrepancy

1

In the [Challenge Response Documentation](https://github.com/tavendo/WAMP/blob/master/spec/advanced.md#wamp-challenge-response-authentication) it mentions `CHALLENGE.Details`, but in the [Message Definitions](https://github.com/tavendo/WAMP/blob/master/spec/advanced.md#message-definitions) it's called `CHALLENGE.Extra`. It doesn't matter one way or the other (I prefer `Details`) but it should...

WAMP ordering guarantees

1

Turnpike currently doesn't guarantee the event ordering in the spec. https://github.com/tavendo/WAMP/blob/master/spec/basic.md#ordering-guarantees

Break package into client and router

4

It seems unfortunate that in order to use Turnpike's client API you have to import the entire router implementation. It seems like splitting the package would make things a bit...

Currently we aren't closing the websocket connection correctly according to the spec: https://tools.ietf.org/html/rfc6455#section-7

If two clients send requests with request ID "1", the second will overwrite the first and the first will never be returned. This is related to #80.

Don't send nil Arguments or ArgumentsKw

2

https://github.com/tavendo/WAMP/blob/master/spec/basic.md#call-1 https://github.com/tavendo/WAMP/blob/master/spec/basic.md#empty-arguments-and-keyword-arguments Specifically in RESULT messages, but we should check INVOCATION and possibly others.