turnpike icon indicating copy to clipboard operation
turnpike copied to clipboard

Don't send nil Arguments or ArgumentsKw

Open jcelliott opened this issue 10 years ago • 2 comments

https://github.com/tavendo/WAMP/blob/master/spec/basic.md#call-1 https://github.com/tavendo/WAMP/blob/master/spec/basic.md#empty-arguments-and-keyword-arguments

Specifically in RESULT messages, but we should check INVOCATION and possibly others.

jcelliott avatar Feb 04 '15 21:02 jcelliott

#9 would hopefully prevent things like this from happening in the future, but I don't know if the current test framework actually tests WAMP or if it just tests WebSockets.

If such a thing doesn't exist, perhaps we should create one?

beatgammit avatar Feb 04 '15 22:02 beatgammit

@beatgammit said:

Fixing this in the serializer is probably the best place to do it, since that prevents null from ever accidentally making it in.

We can also add a simple check in a few places like this

jcelliott avatar Feb 04 '15 22:02 jcelliott