Juan Benet

Results 431 comments of Juan Benet

We need: - [ ] flesh out the sharness test suite to test all the algorithms, lengths, etc - we can define the sharness test suite as the bin's "api...

In js-land, we also need: - [ ] making the js-multihash bin to conform to this test suite - [ ] adding the test suite to js-multihash/js-multihashing @RichardLitt possible for...

@chriscool: yeah, maybe MULTIHASH_BIN ? @Kubuxu: maybe. Let's start with just different test files in the sharness tests and break it out only once needed. On Sat, Aug 6, 2016...

Thanks for this, great bug catch. I think this should probably be an error. Though we _could_ define all extra bytes to _always be zeros_. that way can compare sha1...

@moreati oh for example in a Kademlia DHT for XOR distance between digests.

> How niche (or otherwise) a use case are those? it's not uncommon. im not sure either way, yet. but i hear you, re errors and not creating a misleading...

another option is to actually produce that many bytes of hash. for example, the "111 byte (888 bit) sha1 hash of 'foobar' " ``` go x := "foobar" buf :=...

Well usually one ends up with a hash by finding it-- it was always generated by someone with the data. And most times the hash used for DHTs and so...

Not at all, all of this is useful discussion.