Jonathan Beliën comments

Results 216 comments of


                                            Jonathan Beliën

Nominatim geocoder - returns different results for postalcode before vs after city name

> Can you tell us (all who need the solution and all who read this issue, and so on ...) where in which file of geocoder-php/nominatim we have to change...

Nominatim geocoder - returns different results for postalcode before vs after city name

Please dive in our code a little bit more (or check how it's done in other providers), we have the `GeocodeQuery::withData()` function exactly for that purpose: https://github.com/geocoder-php/Geocoder/blob/master/src/Common/Query/GeocodeQuery.php#L131

ProviderCache: Add option to separate cache between providers

Hello @AntoineLemaire , Thank you for your contribution. It looks good to me. Could you add a test for this new feature ? Thanks.

Should have a "minimum-stability" description at documentation?

Thanks for your feedback @marcosfreitas ! It should work with `"minimum-stability": "stable"`, I'll check why it doesn't !

Adding provider ipfinder

Hello, Can you make sure your PR passes all the tests ? Thanks a lot !

Adding provider ipfinder

Could you also add some specific tests ? Check another [IP provider](https://github.com/geocoder-php/Geocoder#ip) to have "examples".

Adding provider ipfinder

@benemohamed Would you have time to finish this PR (and merge our `master` to fix the conflict) ? Thanks.

Adding provider ipfinder

Thanks for the notice @Chris53897, I guess we can close this PR then.

Update Readme.md

Hello @oichou , I'm a bit confused ... Why did you close #1132 to open a new PR with the exact same modification ?

Update Readme.md

Oh okay, it was not necessary but not worries. I'll check it ASAP.