Geocoder icon indicating copy to clipboard operation
Geocoder copied to clipboard
verified publisher icon geocoder-php

Adding provider ipfinder

Open benemohamed opened this issue 6 years ago • 5 comments

Hi Adding provider ipfinder.

benemohamed avatar Sep 21 '19 20:09 benemohamed

Hello,

Can you make sure your PR passes all the tests ? Thanks a lot !

jbelien avatar Sep 25 '19 08:09 jbelien

Could you also add some specific tests ? Check another IP provider to have "examples".

jbelien avatar Sep 25 '19 11:09 jbelien

I'm a bit concerned that you made this PR without disclosing you affiliation with the provider (it seems you created it).

I can't even find the website searching for the company name "ipfinder"

atymic avatar Sep 26 '19 01:09 atymic

@atymic the website https://ipfinder.io/

benemohamed avatar Sep 26 '19 12:09 benemohamed

@benemohamed Would you have time to finish this PR (and merge our master to fix the conflict) ? Thanks.

jbelien avatar Oct 10 '20 10:10 jbelien

Looks like the website https://ipfinder.io/ is down.

Chris53897 avatar Sep 05 '22 20:09 Chris53897

Thanks for the notice @Chris53897, I guess we can close this PR then.

jbelien avatar Sep 06 '22 08:09 jbelien