Jonathan Beliën

Results 216 comments of Jonathan Beliën

Thanks a lot @franzwilding ! 👍 I'll have a look at it as soon as possible.

Yeah, I think we really need to normalize our admin levels ! There is a discussion about it in my issue #852 (I still need to take care of it)....

Hello @mwisner , Documentation seems indeed to mention a `region_name` (see https://ipstack.com/documentation#objects). Would you be able to submit a PR ? Thanks !

You have to submit your PR in [**this** `geocoder-php/Geocoder` repository](https://github.com/geocoder-php/Geocoder/) in the [`src/Provider/Ipstack` folder](https://github.com/geocoder-php/Geocoder/tree/master/src/Provider/Ipstack). The [`geocoder-php/ipstack-provider` repository](https://github.com/geocoder-php/ipstack-provider) will be automatically updated once your PR is merged.

Thanks @BrodyT , Could you add a test for this ?

I would like to add `float` type to `createCoordinates()` parameters https://github.com/geocoder-php/Geocoder/blob/fce4473c2c7db8d455eb31176282c3eb5ae6ea30/src/Common/Model/Address.php#L279 but I noticed than type is not currently "forced" because some provider send `string` to that function and it's...

> We dont plan to make a new major release, right? That's the question indeed :P

Okay, I'll let this PR pending then ! 👌 I release a minor release for each provider following the last updated !

Thanks for the fix @comxd ! Could you add a test for this ?

Hello @lathamios , That would be interesting indeed. Could you provide a Pull Request with this ? Or at least documentation on the API ? I found this (https://developer.apple.com/documentation/mapkitjs/mapkit/geocoder) but...