IPStack provider doesn't set administration area.

[mwisner]

IPStack service does return region_name and region_code, but the provider doesn't seem to convert them into an administration area for the address model.

https://github.com/geocoder-php/Geocoder/blob/master/src/Provider/Ipstack/Ipstack.php#L104-L112

[jbelien]

Hello @mwisner ,

Documentation seems indeed to mention a region_name (see https://ipstack.com/documentation#objects).

Would you be able to submit a PR ? Thanks !

[mwisner]

Hi @jbelien,

Sorry for the silly question but I'm kind of confused about where to actually contribute.

I see there are providers here: https://github.com/geocoder-php/Geocoder/tree/master/src/Provider/Ipstack

But there is also a repo here: https://github.com/geocoder-php/ipstack-provider

and both sets of code look the same, but they both have READY ONLY in the readme and whatnot.

I found this documentation: https://github.com/geocoder-php/Geocoder/blob/master/CONTRIBUTING.md

But it looks like it just covers code quality and PR review.

Is there another spot for documentation around which area to contribute to?

Thanks!

[jbelien]

You have to submit your PR in this geocoder-php/Geocoder repository in the src/Provider/Ipstack folder.

The geocoder-php/ipstack-provider repository will be automatically updated once your PR is merged.