Jonathan B. Coe comments

Results 19 comments of


Jonathan B. Coe

Suggestion: Guidance for calling non const methods from const via pointers (std::propagate_const, gsl::owner,not_null...)

Re: "This may also be an argument for pushing the use of references over non-owning pointers." references have the same const-propagation issues as pointers when used as member variables.

Make null-state non-observable

Should we make `indirect_value` non-default constructible or should we live with the API difference? From a teachability standpoint, symmetry is appealing.

Add a GDB pretty-printer

See https://github.com/jbcoe/polymorphic_value/issues/91 for implementation guidance.

Add customisation for std::formatter inline with p1636r2 for unique_ptr/shared_ptr

Agreed that this is a good idea.

Ensure that indirect_value can be passed in a register when the copier/deleter are empty

It looks like this might need language changes: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p1029r3.pdf https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1144r2.html

Add a small buffer optimisation

Hi @NikBomb I'm behind on tracking my issues. An opt-in SBO would be really cool. We might want it controlled by some preprocessor definitions so that we can control how...

Add a small buffer optimisation

I believe that SBO can be done purely with allocators. Closing this issue.

Make null-state non-observable

Docs need updating to merge this but I want to see what the API and coverage stats look like.

Make null-state non-observable

We are abandoning this approach due to undesirable semantics of optional types with pointer-like interfaces.

An alternative implementation with a small buffer optimisation (SBO)

We've had a very long think about this and it's forced us to make a decision about polymorphic_value supporting a small-buffer optimisation. polymorphic_value is designed to do a strictly better...