jbaehr

Results 34 comments of jbaehr

While I am interested, I don't see a time frame for that anywhere in the near future. I'd suggest zu reuse as much as possible as-is. From the commit history,...

Please note that there is a second forum thread about this PR: https://forum.freecadweb.org/viewtopic.php?f=17&t=65903, which is unfortunately not linked from the original description. Where should the discussion finally take place?

> After more thinking I came to the conclusion that the best solution would be to execute the GitVersion logic in-process with MSBuild so that it is tied to the...

> > The cache however, is a private implementation detail, so this could be switched to some other format, optimized for fast parsing. It does not require to be portable...

> Do you have any idea how much refactoring this would require? Not really... It's been a long time since I poked around in the code base; still in the...

Just changing the check from ">= 19" to ">= 18" may fall a bit short. According to [this form discussion](https://forum.freecadweb.org/viewtopic.php?f=10&t=54370&start=10#p513786) the change was made during the 0.19 release cycle. If...

> Note that the current check fails if the versionstring contains a decimal. int('19.8') --> error That looks very strange, indeed (where "strange" means "completely unexpected to *me*"). In which...

I just tried it on the develop branch. cool stuff! I've one addition/enhancement to propose: What do you think about two additional (hidden?) computed properties `max_{head,root}_fillet`, with the maximum possible...

> ... tip/root radius (which is how it is called in the standards usually) Which standard are you referring to? ISO 1122-1:1998 "Vocabulary of gear terms" (publicly available as [Indian...

> I also noticed that when using Face binders with gears, I can predictably bind the top and bottom faces of gears when they are **NOT** helical gears, even when...