asciidocnet icon indicating copy to clipboard operation
asciidocnet copied to clipboard

ensure compatibility using asciidoctor's tests

Open jbaehr opened this issue 7 years ago • 4 comments

asciidoctor comes with a rich test suite. Is it possible to run asciidocnet against those tests, using Iron Ruby?

jbaehr avatar Jan 31 '17 16:01 jbaehr

It would be awesome if it could but looking through the tests, they look to be tightly integrate with Asciidoctor's implementation. Porting them over could be an option

russcam avatar Feb 03 '17 12:02 russcam

@jbaehr would you be interested in helping port them over? I'm implementing table parsing at the moment and tidying up the codebase (it needs some ❤️)

russcam avatar Mar 14 '17 22:03 russcam

While I am interested, I don't see a time frame for that anywhere in the near future. I'd suggest zu reuse as much as possible as-is. From the commit history, Asciidoctor's test suite seems to be a quite moving target. In order to benefit from their ongoing invest, it may be possible to only reimplement their test_helper.rb. Or even better, setup some ruby facade for asciidocnet, acting as Asciidoctor's API in the tests. I think we can benefit from Ruby duck-typing approach here.

Regarding some code base tidying... Do you know Markdig? It has a pretty neat architecture; maybe it's even possible to implement asciidocnet on top of it.

jbaehr avatar Mar 15 '17 21:03 jbaehr

I'm familiar with Markdig, particularly like the string slicing and avoidance of regular expressions 😄 Would be keen to leverage as much as possible and reduce the burden on re-implementing it

russcam avatar Mar 16 '17 07:03 russcam