Dan Miller comments

Repositories
Issues
Comments

Results 25 comments of


                                            Dan Miller

Allow NIX_* environment variables to be passed to rustc

Yeah I am not attached to this solution at all. Something like `inherited_envs` sounds good to me, but curious to hear from folks more experienced than I.

Fix URL of Windows artifacts

This is also probably fixed by #8

rust-project: remove hardcoded mode file in OSS build

I have this test too but not sure how useful it would be ```rust fn test_select_mode() { // Test default behavior without the fbcode_build feature assert_eq!(select_mode(None), None); assert_eq!( select_mode(Some("custom-mode")), Some("custom-mode".to_owned())...

rust-project: remove hardcoded mode file in OSS build

@davidbarsky done!

nix: not found on root user PATH using sudo after linux multiuser install

I can also reproduce this on Linux/aarch64