Phil Dibowitz comments

Results 437 comments of


                                            Phil Dibowitz

Fix call to install_snaps which is missing an argument

We should add some tests here, it's sad this broke so bad. If you add some `snap` resources in this recipe: https://github.com/chef/chef/blob/main/kitchen-tests/cookbooks/end_to_end/recipes/_snap.rb And then you add some `inspec` to verify...

Fix call to install_snaps which is missing an argument

This is great, the tests all look good (thanks!) the failing test isn't your fault. We'll merge this as soon as the 18RC is out the door.

Fix call to install_snaps which is missing an argument

yes. getting the test piplines working is part of getting the RC out the door. It wont' be merged without the tests passing. :)

Supported Hierarchical Departments

CC @jonas054 who wanted a tag in this.

Fall back to /proc/cpuinfo if lscpu doesn't have CPU totals

Ping @stanhu

Empty volume name on Windows results in an empty by_device key

Well, the Volume name - which is the equivalent of device in windows - is `""` so in the `by_device` hash, the key is `""`. This... feels like exactly the...

fix warning: already initialized constant MACROS_MARKER and warning: …

ping @jkimalane

Use a minimum of 1 thread per core for CPU total calculation

> > Please update the description to show why the default cpu is configurable. > > @johnmccrae Could you elaborate? I don't quite understand. @stanhu - Your change to do...

Use a minimum of 1 thread per core for CPU total calculation

Ping @stanhu ?

Use a minimum of 1 thread per core for CPU total calculation

Thanks!