Phil Dibowitz
Phil Dibowitz
I don't think the test failures are related, but we should get tests working before we merge this so we can see if this breaks anything - @marcparadise and @johnmccrae...
Thanks! Approved tests, lets see if we're in a better state
@sabat thanks! Can you rebase, all the test failures you are hitting have been fixed. Sorry!
> Any REST API things are currently broken due to the missing `require` and the wrong data handling of skipping `.data`. It will just crash if you want to do...
@tecracer-theinen - aahhhh - I hadn't realized this was a new resource! In that case you're 100% correct, this is safe/good to merge.
So you can add a property the way it's done here, in the resource: https://github.com/chef/chef/blob/main/lib/chef/resource/apt_package.rb#L63 So you might make one called `anchor_package_name_patterns` for example, in that file. Which just makes...
The code looks better, but the tests aren't quite covering what we want, in two ways: 1. two levels of partials is a base-case, so we'd really want to check...
@tecracer-theinen - Are you still interested in getting this PR merged? It's very close to being ready, and now that 18GA is out, we're ready to merge PRs again.
@mikedodge04 - Just for a quick sanity check - can you tell me if these defaults seem idiomatic to you as someone who manages a fleet-o-macs?
@natewalck - that seems like the change we're making here - host=any is what you are suggesting. So I think we're on agreement on the host settings, yes? But I'm...