Phil Dibowitz
Phil Dibowitz
OK, option 1 implemented. Plus a few typos in comments fixed.
@nikhil2611 - updated tests are failing.
Can you do this as a fork, so we can see the results before we merge it, please?
@tpowell-progress - need conflict resolution
FYI - we can't merge this as-is. We need to checkout the PR commit, because `pull_request_target` runs on the _base_ of the PR, not the PR commit.
@dhimanck - ping?
@dhimanck - pinging one more time. Can you please fix the errors? We'll close next week if we don't hear back from you.
@dhimanck The unit test on the specific code you're changing is failing: ``` 1) Chef::Resource::RhsmRegister#registered_with_rhsm? when the status is anything else returns true Failure/Error: expect(provider.registered_with_rhsm?).to eq(true) expected: true got: false...
@dhimanck - @dschlenk 's suggested code [here](https://github.com/chef/chef/pull/15409#issuecomment-3474946626) seems like a better call. That said - I don't love the string matching in general - is the return value from the...
> > @dhimanck - @dschlenk 's suggested code [here](https://github.com/chef/chef/pull/15409#issuecomment-3474946626) seems like a better call. > > That said - I don't love the string matching in general - is the...