Jay Conrod

Results 194 comments of Jay Conrod

@drigz Right, there's no longer anything blocking us from running a tool invoked by `bazel run` that writes files in the source directory.

> in non-pure mode some of the binaries has build id, and some don't. That's surprising. We shouldn't be setting that in `go_binary` unless it's done explicitly in `gc_linkopts`. Is...

If you need a unique id per binary, it sounds like auto-generating something may be the best option. I'm told that "go build" in Go 1.10 has started doing this...

Looked into this a bit more. I don't think the Go internal linker ever sets the build id unless the `-B` option is used explicitly. However, the external linker (i.e.,...

Sorry that didn't work. It sounds like a build id needs to be explicitly passed to the internal linker, and it probably should be generated from inputs. The easiest place...

The `options` flags here don't seem quite right to me, but I'm not sure what the right values would be. `go_proto_compiler` invokes protoc with an argument like: ``` --foo_out=opt1,opt2:dir ```...

I think that can happen if a plugin doesn't generate any output files. `go_proto_compiler` will write a file like that in the absence of anything else.

Setting `valid_archive` to `False` means that compiler won't produce a complete, buildable archive. Specifically, it means that a `go_proto_library` target that uses *only* that compiler won't provide `GoArchive`, meaning it...

Bazel normally runs tests in a temporary sandbox directory. It creates symbolic links to runfiles. Windows forbids creation of symbolic links unless you have administrative privileges, so Bazel doesn't run...

This issue is in response to [Bazel build, protobuf and code completion](https://stackoverflow.com/q/44375665/1891). TODO: update answer when this issue is resolved.