Jay Conrod

Results 194 comments of Jay Conrod

@hlopko The issue here was a regression in coverage support in 0.27.0. It should be fixed in 0.27.1. I think the tests were just picking up `bazel` from `PATH`. I...

@jakemcc This isn't safe unless the .zip file is mirrored somewhere else, too. .zip files from that endpoint are prepared on demand. The SHA-256 sum can change over time, since...

When testing with this flag on in rules_go at `dd527c7d` with Bazel 0.26.0rc8 on macOS, I'm seeing this error: ``` $ bazel build --incompatible_enable_cc_toolchain_resolution tests/legacy/examples/cgo:sub > > Loading: Loading: 0...

This sounds good. One note: `emit_compilepkg` is the new package building implementation that should be updated. `emit_compile` is obsolete and probably shouldn't be updated.

cc @ianthehat I share some of @FiloSottile's concerns. Allowing users to override std dependencies, especially crypto dependencies, is scary. But not allowing this would be against the spirit of modules....

I'm definitely sympathetic to reducing code duplication and binary size, but I'm also concerned about complexity and special cases. I think we should resolve #26924 using the `internal/x` approach in...

@bcmills I agree that this is probably the simplest way to make module-mode vendoring work in the standard library in terms of new code that needs to be written. My...

Before proceeding with the vendoring changes, I would feel a lot better if @rsc and @ianthehat LGTM'd this proposal, and I want to make sure @FiloSottile is satisfied. What do...

> I would agree with you a priori, but as I understand the current state of the world, the introduction of the build cache broke this case many releases back,...

> 1. Change the net package to not require a C compiler on macOS. I wonder how viable this is? I know very little about the guts of the `net`...