Jay Conrod

Results 194 comments of Jay Conrod

My overall thought is that Bazel / rules_go should print the same errors the Go compiler prints when building the same packages without adding much extra information that gets in...

@yicm rules_go does support platform-based construction. The document you linked is out of date, as noted at the top. Not sure how that `go build` command is related to this...

Ideally I think Gazelle extensions should live in the same repos where the rules are defined. That way, the extension can be coupled with the rules being used. Rule authors...

cc @juliexxia If moving the package isn't an option, renaming `//gazelle:gazelle` would be a narrower fix.

@achew22 Good idea. I've started bazelbuild/bazel-gazelle#857 for that, but I can't finish it until this one is merged.

I don't have write access in this repo. Someone else will need to hit the button. @juliexxia Could you confirm this will work with the Copybara import? I'm not sure...

Hmm, the only thing in this PR that might have affected this test was moving `--output_user_root` to `.bazelrc`. I would think that would have no effect on `bazel cquery` and...

All right, tests are green. The reason why I was seeing `hermeticity_test` fail on master was that I was missing some environment variables that are set in CI. After finding...

I'd be grateful if someone can merge this. Google revoked all my powers here when I left, so I'm just a regular citizen now.

Are there tests for `gopackagesdriver`? I didn't see a place to add a test case. If I missed it, please let me know, happy to add.