Jayant Bhawal
Jayant Bhawal
@adnanhashmi09 @samad-yar-khan might be better suited to confirm.
I think a simple check that runs at the start of the script to check that all versions are correct will do, and if something is off, it specifies which...
That's where the "exploring the codebase" part comes in. :) I expect you'll find something in `dev.sh` or the `cli` submodule.
I think the shifting input field feels unpleasant to the eye. Everything else is fine though. A simple change would be to just add a save button to the bottom...
I was thinking to not set a maximum... but, let's start by setting it to 366 days. @Kamlesh72
@Kamlesh72 were the visual changes that I requested, made? Asking because a bunch of other discussion has happened, and I wonder if I missed it. :) No pressure, just ensuring...
Just one tiny change. Make the confirmation action (Save) be on the right, and the rejection action (Discard) be on the left. That's generally how accept/reject CTAs work everywhere. :)...
I've approved it, but I'd like @samad-yar-khan or @adnanhashmi09 to also cross check.
You guys sure this PR can't use ~11 more comments? 😛
The initial PR and the PR in its current state is significantly different. Great growth @Kamlesh72 👏🏽 This must have been something to persevere through, but great job sticking to...