Jayant Bhawal
Jayant Bhawal
And of course, to test the performance of how many lines you're able to process via your functions as a benchmark.
I ran a quick test myself based on the number of lines, and I think we'll hit other performance limits before we hit perf issues with the regexes and matches.
No no. I'm saying you might not need to change your approach.
> This PR could use some tests. Especially with various kinds of logs that might come through. This.
I think handle for the variety of logs that are generated today. But ensure that when and if something unexpected comes in the logs (such as, missing HTTP method in...
I suspected it could go in this way. You can go with a simpler approach altogether as well.
> > I suspected it could go in this way. You can go with a simpler approach altogether as well. > > Then , there will be some logs, which...
Looks better. :) Could you use Error Boundaries to show the logs in completely plain-text (the view before your changes that is) in case something breaks in the off chance?...
Hmm, not sure I feel great about that approach. How did you try to add and test the error boundary that it caused a higher level boundary to catch it...
@vishalmishraa could you share screenshots of the error boundary in effect?