Jonathan Sifuentes

Results 11 comments of Jonathan Sifuentes

Are we to process the args and stuff raw, or would an outside dependency like [`yargs`](https://github.com/yargs/yargs) acceptable?

I'd say go ahead, personally

I'm currently working on this. I just can't seem to raise the code coverage for the branches: ![Screenshot of code coverage](https://user-images.githubusercontent.com/1018901/37242782-ddb2f804-2423-11e8-8bf4-ce419994b19c.PNG) Of course, I also took some...liberties as well: jayands/plasmajs@cc4b2edf0ccf52b8d25df53d8dddebbda247e54e,...

Also, may I suggest the following as well? - [ ] De-JSX-ify the files #12 - [ ] Use Jest for testing #13 - [ ] Airbnb config #14

Okay, I don't know why I didn't think of this before, but I fired up Node (10.9.0). @themasch, you're correct in that > I highly doubt that you can have...

Hey, get this! There was a BigInt added to Node 10.7! See [this article][v8] for the post announcing it, as well as the TC39 proposal for it being at [Stage...

@OllieJones could you check if the IIFE version, output by Rollup, solves your needs? It should be available in the `browser` field in v3.

See 5adf860617ed7e6aae4c0dd8684e130b82bbead2. It needs review, but otherwise should be properly implemented.

Does `EbmlDecoder.prototype._schema` absolutely *have* to exist? I mean, I know that realistically, most use cases should only have one encoder and decoder, but it's supposed to be a private, read-only...

Thank you. If you have a fix, feel free to submit a pull request, otherwise I will get on it ASAP.