plasmajs icon indicating copy to clipboard operation
plasmajs copied to clipboard

Published 20 hours ago • verified publisher icon phenax

Need better tests

Open phenax opened this issue 7 years ago • 4 comments

Need test suites for the server, history api and middlewares.

phenax avatar Nov 23 '16 08:11 phenax

Hi, I'd like to work on this issue, if that's alright. Let me know if that's OK!

mperitz avatar Jun 13 '17 16:06 mperitz

@mperitz Sure. Feel free.

phenax avatar Jun 14 '17 12:06 phenax

I'm currently working on this. I just can't seem to raise the code coverage for the branches: Screenshot of code coverage

Of course, I also took some...liberties as well: jayands/plasmajs@cc4b2edf0ccf52b8d25df53d8dddebbda247e54e, mainly with code formatting opinions. Edit: Also with the use of Lodash, because it's awesome.

I was wondering, though: why not @babel/preset-env? Edit: Babel recommends using preset-env instead of the various es201X presets, so that will be next in the line of changes.

jayands avatar Mar 10 '18 14:03 jayands

Awesome. I was planning on refactoring the styles and the build process anyway because it's pretty outdated.

PS - This is not related to the tests so you can create another issue for it.

phenax avatar Mar 13 '18 06:03 phenax