Jason Malinowski

Results 83 comments of Jason Malinowski

Right now creating this to ensure no functional/performance regressions in divisional tests before we flip the feature flag. This will merge at some later point when we're comfortable with it.

Internal validation run passed, so this is ready for review.

@CyrusNajmabadi Actually in that case then I can just flip the existing feature flag on, and we can just merge this in 17.6.

This is being merged into 17.6, but the existing feature flag is being flipped for 17.5.

@CyrusNajmabadi So we've had this feature flag rolled out to 100% of users for awhile with few reported issues so I'd like to merge this for 17.7; I don't see...

@CyrusNajmabadi Ready for review then after resolving merge conflicts.

Still not sure if we have it formally written up. I guess we need to get on that. @jmarolf did we do this somewhere?

@HintonBR: those changes are in the final product.

@HintonBR Which setting were you trying?

@AArnott which generator/scenario is this? Because I'd agree with @CyrusNajmabadi if the diagnostics were costing extra to compute, but if it's otherwise no additional cost _and_ the generator is regularly...