Jason Malinowski

We don't have any public cleanup API for this, just the building blocks. Don't forget that promotion itself requires semantics: if you have "using C" inside a namespace A it...

@iSazonov shared the implementation in another issue as https://github.com/iSazonov/PowerShell/commit/80e5ba9b40654d67d0276a006d2572f78b932b46 I'm not sure if this is because of the System.Reflection.MetadataLoadContext reference there; the that's going to be bringing in other dependencies...

> Your Generator project must target netstandard2.0 instead of net6.0, not sure why it breaks the omnisharp and Visual Studio 2022, but dotnet cli tool works. Omnisharp and Visual Studio...

The customer's sample code looks right, at least at first glance. I've reached out to the MSBuild team for advice here.

@WeihanLi Ah thanks for the ping -- my back and forth with that team got lost in everything else going on. Just to confirm, what version of the SDK are...

@dibarbet Did we already fix this? I assume we'd be getting lots of reports if we hadn't.

This work was originally introduced in https://github.com/dotnet/roslyn/pull/7417, so tagging @CyrusNajmabadi if he can recall if there was something we missed here. I get the sense from the commentary there that...

@tmat: we may also want to update https://github.com/dotnet/roslyn/blob/4a1f4d37f0d68fa71e290d1a0efae5ace6ee5edd/src/Compilers/Core/MSBuildTask/Microsoft.CSharp.Core.targets#L188 and the equivalent bit for VB here. Even though we don't have to reparse a tree because of the checksum algorithm changing,...

@tmat: one set of tests I didn't see anywhere (unless I missed it) was some tests around solution sync to verify that changing the checksum actually worked right.

@tmat I'd also expect one or two tests on VisualStudioProject directly ensuring the end-to-end actually reading a file from disk works, since that'll actually ensure much of this works in...