roslyn
roslyn copied to clipboard
Remove the feature flag and change the default for open generated files
Right now creating this to ensure no functional/performance regressions in divisional tests before we flip the feature flag. This will merge at some later point when we're comfortable with it.
Your PR Validation run is out of date and contained failures.
Internal validation run passed, so this is ready for review.
This def worries me. But i guess we have feature flag to roll back if this causes an issue?
Ok. So i'm fine flipping this on by default. But i'd say we should still have an available flag to disable thsi remotely if it turns out to be an issue.
@CyrusNajmabadi Actually in that case then I can just flip the existing feature flag on, and we can just merge this in 17.6.
That works for me.
This is being merged into 17.6, but the existing feature flag is being flipped for 17.5.
Target main since it is 17.6 now
@CyrusNajmabadi So we've had this feature flag rolled out to 100% of users for awhile with few reported issues so I'd like to merge this for 17.7; I don't see any reason to keep this feature flag around at this point.
Works for me!
@CyrusNajmabadi Ready for review then after resolving merge conflicts.