roslyn icon indicating copy to clipboard operation
roslyn copied to clipboard

Remove the feature flag and change the default for open generated files

Open jasonmalinowski opened this issue 2 years ago • 8 comments

jasonmalinowski avatar Apr 27 '22 00:04 jasonmalinowski

Right now creating this to ensure no functional/performance regressions in divisional tests before we flip the feature flag. This will merge at some later point when we're comfortable with it.

jasonmalinowski avatar Apr 27 '22 00:04 jasonmalinowski

Your PR Validation run is out of date and contained failures.

JoeRobich avatar Jun 13 '22 21:06 JoeRobich

Internal validation run passed, so this is ready for review.

jasonmalinowski avatar Dec 06 '22 20:12 jasonmalinowski

This def worries me. But i guess we have feature flag to roll back if this causes an issue?

CyrusNajmabadi avatar Dec 06 '22 20:12 CyrusNajmabadi

Ok. So i'm fine flipping this on by default. But i'd say we should still have an available flag to disable thsi remotely if it turns out to be an issue.

CyrusNajmabadi avatar Dec 06 '22 20:12 CyrusNajmabadi

@CyrusNajmabadi Actually in that case then I can just flip the existing feature flag on, and we can just merge this in 17.6.

jasonmalinowski avatar Dec 06 '22 22:12 jasonmalinowski

That works for me.

CyrusNajmabadi avatar Dec 06 '22 23:12 CyrusNajmabadi

This is being merged into 17.6, but the existing feature flag is being flipped for 17.5.

jasonmalinowski avatar Dec 12 '22 20:12 jasonmalinowski

Target main since it is 17.6 now

Cosifne avatar Jan 04 '23 20:01 Cosifne

@CyrusNajmabadi So we've had this feature flag rolled out to 100% of users for awhile with few reported issues so I'd like to merge this for 17.7; I don't see any reason to keep this feature flag around at this point.

jasonmalinowski avatar Jun 19 '23 21:06 jasonmalinowski

Works for me!

CyrusNajmabadi avatar Jun 19 '23 22:06 CyrusNajmabadi

@CyrusNajmabadi Ready for review then after resolving merge conflicts.

jasonmalinowski avatar Jul 21 '23 23:07 jasonmalinowski