Jason Heath

Results 19 comments of Jason Heath

> What is the warning this is addressing? Looks like it is likely not valid based on the pipeline failures. Capturing offline discussion here. This file was triggering warn(dead_code) on...

Fair point. I’ve been delivered not one but two thanksgiving turkeys this afternoon. This likely explains a mystery bug I’ve been hitting in my testing today and finally had to...

Here's the changelog for 5.1.0. > notify 5.1.0 (2023-01-15) > > CHANGE: switch from winapi to windows-sys https://github.com/notify-rs/notify/pull/457 > FIX: kqueue-backend: batch file-watching together to improve performance https://github.com/notify-rs/notify/pull/454 > DOCS:...

> > How would you like to handle? For us, its really all about that change on the windows crate as since we don't use kqueue. I can argue for...

> It looks like `Path` does not transform a `/` to a `\` and therefore you would need to check for both on windows since `/` is a legal substitute...

> Still making my way through the tests but wanted to drop this one comment now. > > There are a lot of tests and parts of tests that are...

@habitat-sh/repo-standardizers, please review and merge at your convenience

@dependabot ignore this minor version

@dependabot reopen Seeing if dependabot will reopon this against the 0.60.2 version of the crate. If that doesn't work I'll try a recreate.