habitat icon indicating copy to clipboard operation
habitat copied to clipboard

Published 20 hours ago • verified publisher icon habitat-sh

address easy warnings in service.rs of component/sup

Open jasonheath opened this issue 2 years ago • 3 comments

Signed-off-by: Jason Heath [email protected]

jasonheath avatar Sep 20 '22 12:09 jasonheath

Deploy Preview for chef-habitat processing.

Name Link
Latest commit 74f78226d895bd4d260bd52df435211e8ef2b7c9
Latest deploy log https://app.netlify.com/sites/chef-habitat/deploys/632b6fb528cbd9000a4eeb79

netlify[bot] avatar Sep 20 '22 12:09 netlify[bot]

What is the warning this is addressing? Looks like it is likely not valid based on the pipeline failures.

mwrock avatar Sep 20 '22 13:09 mwrock

What is the warning this is addressing? Looks like it is likely not valid based on the pipeline failures.

Capturing offline discussion here. This file was triggering warn(dead_code) on a use stmt and a function. Both are used in an async block so my suspicion is that the async was throwing the linter off. Change is ultimately to #[allow(dead_code)] and #[allow(unused_import)] with comments as to why. Build failed the first time around because the "use crate::test_helpers::*" couldn't be removed as it was being used async.

jasonheath avatar Sep 21 '22 11:09 jasonheath