Jason Day

Results 115 comments of Jason Day

Thanks for digging in @evanb2 , this explains a lot and is likely similar/same to #152 This has implications across the board and will require more digging and potential rework...

One option is to not remove the print iframe at all. This goes against the best practice of not removing things added to the DOM when done, but it may...

Won't merge with 1.x. The browser stops all processing/rendering when the print dialog is open and restarts when the print dialog is closed. With this pull request, the `complete.printThis` is...

What browsers were tested? Additionally, removing the `if(!opt.debug)` logic will break the debug functionality. That logic would need to be in place within your change to line 317. Please make...

Thanks, I'll look further. I worry that the "framing" of the new option may be confusing, as `keepIframe` indicates that the iframe is kept, not removed. I think there's probably...

@oculus42 - depends on what we want to do, but yeah - probably

potential option for event after print, but needs thorough testing: https://www.tjvantoll.com/2012/06/15/detecting-print-requests-with-javascript/ And because `window.matchMedia('print');` fires twice in chrome, this may not be a valid option (and does it fire twice...

Add integration with a pdf generation library.

That's potentially on our list for a version 2, but presents some unique challenges. On Sun, Aug 26, 2018 at 8:58 PM Lucas Hill wrote: > I'm using printThis this...

@mhulse I think your particular issue is separate from OP's. One thing you could try is to increase the printDelay option. My guess is that in your scenario, the print...