printThis icon indicating copy to clipboard operation
printThis copied to clipboard

Planning for Version 2.0

Open jasonday opened this issue 6 years ago • 10 comments

Potential list of to-dos:

  1. Retest $iframe.ready() and $iframe.load browser support
    1. Remove setTimeouts (potential) #85
  2. Match options to be in the same format ("tense")
  3. Add complete event ( #54 ); likely dependent on # 1 above
  4. Universal module #121
  5. or remove jQuery dependencies?

@oculus42 other potential changes?

jasonday avatar Jul 31 '17 04:07 jasonday

I had crazy visions of making the various features into modules that could be loaded.

oculus42 avatar Aug 11 '17 14:08 oculus42

Additional question: Do you want to set a browser support limit for 2.0?

oculus42 avatar Oct 14 '17 18:10 oculus42

@oculus42 - depends on what we want to do, but yeah - probably

jasonday avatar Oct 14 '17 20:10 jasonday

potential option for event after print, but needs thorough testing: https://www.tjvantoll.com/2012/06/15/detecting-print-requests-with-javascript/

And because window.matchMedia('print'); fires twice in chrome, this may not be a valid option (and does it fire twice in chrome consistently?)

jasonday avatar Nov 10 '17 01:11 jasonday

Add integration with a pdf generation library.

jasonday avatar Jul 13 '18 03:07 jasonday

Do you have any idea when the pdf generation would be ready? :)

Geoffry304 avatar Aug 14 '18 06:08 Geoffry304

I'm using printThis this in an ember addon and soon-ish Ember will be removing jquery. So removing the jquery dependency would be amazing. Thanks for the great work.

LucasHill avatar Aug 27 '18 00:08 LucasHill

That's potentially on our list for a version 2, but presents some unique challenges.

On Sun, Aug 26, 2018 at 8:58 PM Lucas Hill [email protected] wrote:

I'm using printThis this in an ember addon https://github.com/LucasHill/ember-print-this and soon-ish Ember will be removing jquery. So removing the jquery dependency would be amazing. Thanks for the great work.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/jasonday/printThis/issues/122#issuecomment-416086644, or mute the thread https://github.com/notifications/unsubscribe-auth/AAtp62CpBTLhXV_h561Xdv9rJCeeIWoHks5uU0QXgaJpZM4On4LG .

jasonday avatar Aug 27 '18 01:08 jasonday

Added a 2.0 project: https://github.com/jasonday/printThis/projects/1

oculus42 avatar Aug 27 '18 01:08 oculus42

Vote for #5

ryanlin1986 avatar Jul 07 '19 06:07 ryanlin1986