Jason Day comments

Results 115 comments of


                                            Jason Day

importCSS: true disables orientation

What are your other printThis settings, and how are you initiating landscape printing?

How can i separate or print 2 selectors on different page?

https://github.com/jasonday/printThis/wiki/Styling-Printed-Content#page-breaks

Print only First Page on Firefox browser

@mujtaba1016 can you provide a bit more information? - What are you printing? - How many pages is it? - Tag classes are copied from the `html` and `body` elements,...

Print only First Page on Firefox browser

Did you inspect the print iframe to ensure all of the expected content is within the iframe? And that there are no formatting issues?

Wait load css and manually run print when document is ready

Hey, I'll take a closer look - thanks. I'm working on a new version, so I may not merge this pull request, but use pieces of it in the new...

Wait for iframe contents to finish loading before triggering print (don't rely on a static delay duration)

@KZeni this is something we are looking into, as we would like to remove all arbitrary timings as they are fragile and problematic. Thanks for the feedback!

support css var change by javascript

Feels like an edge case, but low risk. Will look into it.

support css var change by javascript

I am not going to merge this at this time, as we have the `copyTagClasses` option to copy classes on the `html` or `body` elements, which can cover this use...

support css var change by javascript

@eakkew What I'm referencing is that rather than inlining styles, use classes on the html or body element (which can also be changed dynamically).

[bugfix] mobile printing

Looks good. Do you mind separating out? I'm iffy on approving the hack only approach fully, but would like the PR for people to use. My plan is to look...