James M Snell

Results 646 comments of James M Snell

Yeah, that's intentional. We really should decide what we want to do with it. /cc @addaleax

I'm +1 on this now but I'm sure there are details to work through.

If we don't do `navigator.platform` (which is fine) ... let's start with `navigator.userAgent`, which is defined as part of the WinterCG minimal (https://common-min-api.proposal.wintercg.org/)

@mcollina: > I don't think we should add navigator to Node.js I rarely disagree with Matteo but in this case I have to ;-) There are several APIs exposed via...

With older versions, `--no-warnings` will turn off all warnings. Newer versions also support `--disable-warning={code}` where `{code}` is the specific code associated with an individual warning (if there is one)

Is it possible to add a test for this change?

@nodejs/tsc ... this needs another TSC review.

> This would probably not be spec compliant, [streams.spec.whatwg.org/#readable-stream-default-controller-should-call-pull](https://streams.spec.whatwg.org/#readable-stream-default-controller-should-call-pull) I do not think we are allowed to add additional steps not mentioned in the spec Given that this is for...

Woo! Thanks for getting this started. The need for the flag is unfortunate but definitely required given how chromium is using the API and the conflict that causes with electron....

I'm fine with this change. It does need docs and test updates tho.