node
node copied to clipboard
nodejs
stream: use ByteLengthQueuingStrategy when not in object mode
Use ByteLengthQueuingStrategy when not in object mode
After this PR
Array buffers memory usage is 0 MiB Array buffers memory usage is 0 MiB converting node stream to web stream Array buffers memory usage is 0 MiB Array buffers memory usage is 0 MiB Array buffers memory usage is 0 MiB Array buffers memory usage is 0 MiB Array buffers memory usage is 0 MiB Array buffers memory usage is 0 MiB Array buffers memory usage is 0 MiB reading the chunks Array buffers memory usage is 2 MiB Array buffers memory usage is 31 MiB Array buffers memory usage is 9 MiB Array buffers memory usage is 18 MiB Array buffers memory usage is 9 MiB Array buffers memory usage is 5 MiB Array buffers memory usage is 8 MiB Array buffers memory usage is 17 MiB Array buffers memory usage is 13 MiB Array buffers memory usage is 12 MiB Array buffers memory usage is 19 MiB Array buffers memory usage is 20 MiB Array buffers memory usage is 31 MiB Array buffers memory usage is 11 MiB Array buffers memory usage is 24 MiB Array buffers memory usage is 17 MiB
fixes: #46347
This would probably not be spec compliant, https://streams.spec.whatwg.org/#readable-stream-default-controller-should-call-pull I do not think we are allowed to add additional steps not mentioned in the spec
A previous PR had attempted the same, nonethless would cc @nodejs/whatwg-stream to take a look!
This would probably not be spec compliant, streams.spec.whatwg.org/#readable-stream-default-controller-should-call-pull I do not think we are allowed to add additional steps not mentioned in the spec
Given that this is for our Node.js stream adapters, this change should be fine.
Seemingly related CI failures:
not ok 690 parallel/test-stream-readable-to-web
---
duration_ms: 172.99900
severity: fail
exitcode: 1
stack: |-
node:events:492
throw er; // Unhandled 'error' event
^
Error: ENOENT: no such file or directory, open 'C:\dev\urandom'
Emitted 'error' event on ReadStream instance at:
at emitErrorNT (node:internal/streams/destroy:151:8)
at emitErrorCloseNT (node:internal/streams/destroy:116:3)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
errno: -4058,
code: 'ENOENT',
syscall: 'open',
path: 'C:\\dev\\urandom'
}
Node.js v21.0.0-pre
What are these mean???? I don't understand what happend link
15:29:20 Counting node-test-binary-windows-native-suites. enabledIndex=2
15:29:20 node-test-binary-windows-js-suites: Quiet period groovy=[index < 5 ? 0 : 2 * 60], index=1 -> quietPeriodGroovy=0
15:29:20 quiet period for node-test-binary-windows-js-suites is 0 seconds.node-test-binary-windows-native-suites: Quiet period groovy=[index < 5 ? 0 : 2 * 60], index=2 -> quietPeriodGroovy=0
15:29:20 quiet period for node-test-binary-windows-native-suites is 0 seconds.Finished Build : [#25539](https://ci.nodejs.org/job/node-test-binary-windows-js-suites/25539//) of Job : [node-test-binary-windows-js-suites](https://ci.nodejs.org/job/node-test-binary-windows-js-suites/) with status : [FAILURE](https://ci.nodejs.org/job/node-test-binary-windows-js-suites/25539//console) at 02:41:03
15:41:30 Finished Build : [#21239](https://ci.nodejs.org/job/node-test-binary-windows-native-suites/21239//) of Job : [node-test-binary-windows-native-suites](https://ci.nodejs.org/job/node-test-binary-windows-native-suites/) with status : [SUCCESS](https://ci.nodejs.org/job/node-test-binary-windows-native-suites/21239//console) at 02:41:30
15:41:30 Build step 'MultiJob Phase' marked build as failure
15:41:31 Collecting metadata...
15:41:31 Metadata collection done.
15:41:31 Notifying upstream projects of job completion
15:41:31 Finished: FAILURE
What are these mean???? I don't understand what happend link
This is just some internal CI logic for running tests. What happened in the CI run is that some tests (flaky tests) failed on Windows and FreeBSD also failed. I've retriggered the CI for failed jobs.
