bob icon indicating copy to clipboard operation
bob copied to clipboard

'bob' performance discussion

Open Fishrock123 opened this issue 7 years ago • 5 comments

So, I finally profiled this on my linux box (macOS is useless because of ___channel_get_opt, good luck).

I have documented the results so far in performance.md. I only really tried doing a very large file and have not yet made cases that make many small streams.

The results are looking good. The HDD is the limiting factor of my linux system, and the profiles show file copying has ~7x less CPU time in JS, and zlib transform has ~33% less CPU time in JS. 💥 (C++ time does not seem significantly affected for either case.)

cc @jasnell, @mcollina

Fishrock123 avatar Feb 16 '18 21:02 Fishrock123

This looks amazing and super-promising. The fact that this happens without buffer reuse makes it even more impressive.

What should be the next step?

mcollina avatar Feb 16 '18 22:02 mcollina

/cc @addaleax :-)

jasnell avatar Feb 16 '18 22:02 jasnell

What should be the next step?

I have updated the project's progress as of today, some next steps and status are listed there: https://github.com/Fishrock123/bob/issues/5 :D

Fishrock123 avatar Feb 16 '18 22:02 Fishrock123

Hm, is there anything specific I can provide to this discussion? Overall I’m still somewhat unsure about the general approach, and I don’t see anywhere where suggestions for API or implementation changes have been made on a conceptual level, but if anybody has something they’d like me to take a look at I’d be happy to.

addaleax avatar Feb 16 '18 23:02 addaleax

@addaleax ... mainly want to just keep you in the loop about the activity here. I know you've got other things you're looking at so no worries at all if you don't have the time to actively follow the work :-)

jasnell avatar Feb 16 '18 23:02 jasnell