Joen A.

Results 733 comments of Joen A.

That's a note for all contributors to the project, it's not useful to single out one group of contributors.

I would echo Jay's note. There are some good ideas, good intents. But compent and admin-level theming is increasingly on the radar, which will afford a systematic approach to more...

My above comment aside, 66054 makes a good case for why a dark toolbar as outlined can make sense even before theming. If this passes a good code review, no...

Related, though not for this PR: #66455.

Nice work. Took a stab at some designs in [this Figma](https://www.figma.com/design/hrrqkZCCRmbO8A2VX0aKun/Background-Image?node-id=15-2813&t=8WYZ41SggSPEWbsX-1). The main thing I wanted to address was to illustrate the idea of just moving the entire background image...

The minus to unset is a great argument for making this follow the ItemGroup pattern. And feel free to see if we can keep the "Add background image" CTA right...

Took a stab at an i3 that incorporates the conversation of the reset button being added, and the initial state simply opening the media library. It's not quite working so...

> One question I had, which can be for another PR: should resetting the image also reset other background image settings? When it's part of the toolspanel, no, mainly because...

Nice one. Though I actually think we should be more aggressive. You should never see this state: ![2024-10-18 14 30 22 tt5 local 6591d24de9d6](https://github.com/user-attachments/assets/3852a6f4-f71c-4973-b7ef-654a1004e938) As soon as we exit to...

Thanks for the issue, good one. The double-applied border seems like a bug, the color should definitely only be applied in one place.