Joen A.

Results 739 comments of Joen A.

Let's ship this, as it's a much needed feature. Thank you George 🙏 However, let's follow up shortly thereafter with a couple of visual improvements. This is what it looks...

> However, if the required APIs aren't working correctly, introducing UI doesn't make much sense. Oh I'll refer to you and others for the call here, I was commenting purely...

Thanks for this PR, and thanks for addressing that design so accurately! Despite your theme.json example, I was unable to get these presets to show up under Blocks > Button...

Nice, took it for a spin, now I see the presets: ![status](https://user-images.githubusercontent.com/1204802/209116056-16d99109-7c80-4ef7-bf72-6f42c36a3def.gif) However I see that with or without modifying my theme.json, and weirdly I'm seeing both theme and default...

> By design, selection happens by matching the values. When the shadow values match for both of them, they both are highlighted. It is also same for colors. We might...

This is getting really close, nice work! ![shadow](https://user-images.githubusercontent.com/1204802/210048864-e812bc25-5346-4739-9bfb-c57e424da9f7.gif) It also seems like I must have a ghost of some shadow presets somewhere in a theme.json, as when I switched to...

Thanks for chiming in, I really appreciate some better design inputs on this one. Just to rewind and refocus the main design challenge at hand: which is to provide at...

> I think we should merge this and iterate on the UI in a followup Sorry to be a pain point here, but I'd love to iterate the initial shadow...

As for the specific shadows, should they employ `currentColor`? Otherwise, pure black #000000 is likely best so it works in both light and dark themes.

Thanks for the ping. Definitely seems like a bug to fix. Does it need any design input? Apologies if I'm missing nuance, but this seems mostly like an oversight.