Jarda Kotěšovec
Jarda Kotěšovec
@asmecher Trickiest part here will be couple of new locale keys - any suggestion how to go about them? Maybe separate PR for next 3.4 version just to include strings?
pkp/pkp-lib#6296 Article breadcrumbs use aria-current but do not point to the current page - OJS 3.4
@israelcefrin Thank you! Looks good to me. You mentioned that the aria-current should be used only on links? If thats the case, should not we also update the other cases...
@Vitaliy-1 Oki, good news its just 3.5. Will try to get to that soonish (next week), so its not blocking theme tests, ok?
@Vitaliy-1 Just merged the fix (https://github.com/pkp/ui-library/pull/336). Feel free to close it once you can verify that the tests are working now.
@nibou230 Hi, thanks for the contribution, its certainly useful feature. Only drawback is that this is built on legacy stack and we aim to avoid adding new functionality on this...
@nibou230 That would be great! Some of the things that we are currently using are quite new, therefore there is not enough examples, so I decided to create boilerplate to...
@nibou230 Hi Nicolas, its now merged on main. If you have any further frontend related questions or feedback, let me know. And hopefully on API side someone will chip in...
@Devika008 Thats great update, thank you! Lets keep this focused on the history. Changing tabs to stepper make sense, but is out of the scope of this one. Maybe create...
@nibou230 No idea, so far I just made the component that links to whatever url is passed to it. But to be honest not familiar with the endpoints for downloading...
@nibou230 Thank you for fixing that. Can you please cherry-pick this commit to your ui-library branch to add this page to storybook? https://github.com/jardakotesovec/ui-library/commit/19200fb83992d5ae7559224a8fb0a25cec28dc14 Would like to try test workflow with...