pkp-lib icon indicating copy to clipboard operation
pkp-lib copied to clipboard

Published 20 hours ago • verified publisher icon pkp

Primary colour can't be set from the theme menu

Open Vitaliy-1 opened this issue 11 months ago • 5 comments

Describe the bug In the Appearance -> Theme menu, when trying to set new theme primary colour, changes aren't being saved.

To Reproduce Steps to reproduce the behavior:

  1. Go to Appearance -> Theme menu
  2. Set new primary colour
  3. Click 'Save' button
  4. Refresh the page
  5. See that new colour hasn't been applied, old value is displayed instead

What application are you using? OJS main branch

Additional information This causes failure of tests for all the themes

Vitaliy-1 avatar Mar 11 '24 15:03 Vitaliy-1

Looks like an issue with vue3-color. The parameter here isn't a new value but rather InputEvent. @jardakotesovec, can you take a look?

Vitaliy-1 avatar Mar 14 '24 11:03 Vitaliy-1

@Vitaliy-1 Oki, good news its just 3.5. Will try to get to that soonish (next week), so its not blocking theme tests, ok?

jardakotesovec avatar Mar 14 '24 12:03 jardakotesovec

It fails tests on Travis for the main. I haven't created 3.4 branch yet.

Vitaliy-1 avatar Mar 15 '24 16:03 Vitaliy-1

@Vitaliy-1 Just merged the fix (https://github.com/pkp/ui-library/pull/336). Feel free to close it once you can verify that the tests are working now.

jardakotesovec avatar Mar 19 '24 08:03 jardakotesovec

I've re-run tests for Health Sciences

Vitaliy-1 avatar Mar 22 '24 15:03 Vitaliy-1