ojs
ojs copied to clipboard
pkp
Authors list on reviewers page
ui-library: https://github.com/pkp/ui-library/pull/287 pkp-lib: https://github.com/pkp/pkp-lib/pull/9288
@asmecher Trickiest part here will be couple of new locale keys - any suggestion how to go about them? Maybe separate PR for next 3.4 version just to include strings?
@jardakotesovec Agreed, I could merge a PR to add the new locale keys immediately, then wait to merge the feature addition until the translators have had a bit of time to catch up.
@asmecher this PR https://github.com/pkp/pkp-lib/pull/9495 has just the locale key changes
@MrRob100, thanks, I've merged the locale file changes. Is there an issue filed for this, or just pull requests so far?
Just a pull request. For future reference should there be an issue for this? Even if the pull requests relate to a feature rather than an actually ‘issue’? And each of the pull requests for this feature link to that issue?
Sent from Outlook for iOShttps://aka.ms/o0ukef
From: Alec Smecher @.> Sent: Thursday, November 9, 2023 7:58:10 PM To: pkp/ojs @.> Cc: MrRob @.>; Mention @.> Subject: Re: [pkp/ojs] Authors list on reviewers page (PR #4061)
@MrRob100https://github.com/MrRob100, thanks, I've merged the locale file changes. Is there an issue filed for this, or just pull requests so far?
— Reply to this email directly, view it on GitHubhttps://github.com/pkp/ojs/pull/4061#issuecomment-1804814092, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKPJNGXYKWCN2TMIHJJSSRDYDVNYFAVCNFSM6AAAAAA5X7APHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUHAYTIMBZGI. You are receiving this because you were mentioned.Message ID: @.***>
@MrRob100, yes, please do create an issue; we use those to coordinate changelogs, feature lists, and in particular to connect things together when there are PRs to multiple repositories/branches.
@MrRob100, I've filed an issue to go along with this -- it makes tracking easier when PRs go to many repositories. Can you add a high-level description of the feature over on https://github.com/pkp/pkp-lib/issues/9756? Thanks!
Cherry-picked https://github.com/pkp/ojs/pull/4061/commits/31f1f45de735a5618b29e065ffb4050b353b98fd manually