Jason R. Coombs
Jason R. Coombs
> And an additional question: whether this should be included in the current PR, or proposed separately as a follow-up? This sounds like another feature, but it does sound useful....
> Should `strict_descriptor` option for `repack()` default to True or False? I don't love that there's two implementations here. My reading from the code is that unsigned descriptors are deprecated,...
Also, I just noticed you're a first-time contributor. Thanks for the contribution and nice work!
Thanks for the report. Sounds like a false positive and nothing to do here.
See #228 where this behavior was added. That PR and the one that preceded it were tricky to get right, especially due to the nuances of manipulating the sysconfig variables...
> PyPy has quite a few releases since it added `LDCXXSHARED`. Is this still happening? Based on the linked commits above as recent as Feb 4, it sounds like it...
It sounds as if there's nothing more to do here. I'd still love for distutils to have a test that captures the failure. If someone wishes to author one, I'd...
I still see some test failures. ``` _________________________ setuptools/config/expand.py __________________________ [gw3] linux -- Python 3.10.14 /home/runner/work/setuptools/setuptools/.tox/py/bin/python 206: error: "type: ignore" comment without error code (consider "type: ignore[union-attr]" instead) [ignore-without-code] 291:...
I kind-of like the "before" output, given that the filename is given in the header. Adding more details to the output makes it more likely that the most important detail...
Perhaps this change should go in [pytest-enabler](https://github.com/jaraco/pytest-enabler/blob/4c4ec90c0b50a478ad334c4bf464695022d37a89/pytest_enabler/default.toml#L4-L5) so it applies to any project with mypy installed?