Jason R. Coombs

Results 1062 comments of Jason R. Coombs

Running the tests on 4.0.2 produces a mostly different set of failures, seemingly related to build backend issues. Beginning with 5.0.0, the current set of failures is observed.

> Master is failing now because Tres released an API breaking change in a minor version of pkginfo. I just haven't had time to fix it. There appear to be...

It looks like when 2afda476ef7edb78c216663273a449966549acfd was introduced (#1040), it supersedes the [`username="fakeuser"`](https://github.com/pypa/twine/blob/6fbf880ee60915cf1666348c4bdd78a10415f2ac/tests/test_settings.py#L119) in the tests, allowing keyring to resolve the user's PyPI token instead of the `entered_password`.

I'm unsure the best way forward here. An easy fix might be to disable keyring in tests - mock it out so it always behaves as if there's no password....

@sigmavirus24 or @bhrutledge : Do you have an opinion on how to deal with this scenario? In ddd4ecb, I've drafted "__token__" as default if unspecified. It addresses the issue, but...

In 2c4e4a1, I've committed the changes that allow the tests to pass. Interestingly, not all of 4a2dfb0d44c5f0d195bfe33475e7dd2a26feeeaf had to be reverted. The [fixtures in test_settings](https://github.com/pypa/twine/blob/6fbf880ee60915cf1666348c4bdd78a10415f2ac/tests/test_settings.py#L40) still retain the behavior that...

> As long as `_distutils_hack` exists, we can't have type-checkers scan the vendored version instead. I do very much want to eliminate this hack (https://github.com/pypa/setuptools/issues/3625). > (if pypa/distutils was installed...

While I agree the newer landscape makes this problem easier to address, I believe as you say the issue is still unsolved. I'd like to see generalized support for multiline...

I encountered this problem also and boiled it down to [this repro](/jaraco/dotnet-format-whitespace-error). Clone that repo on Windows with `git config --global core.autocrlf false` and run `dotnet format`: ``` dotnet format...

I don't understand why the proposed fix works, and it seems to affect more than just FileSessions, which is the only Sessions type implicated in this ticket. I'm also not...