Jason R. Coombs

Results 1062 comments of Jason R. Coombs

> > Is there a way to access the dynamic linker's default search directories from python? > > I don't think there is any. I guess there are couple of...

What's the status of this PR? @DWesl are you still working on it? It looks like there was maybe just one lingering concern.

After scanning through the messages, I guess I was mistaken. I see you addressed adding a test and of the two options suggested by isuruf, you elected the second. So...

@DWesl Let me know if you want to continue working on this, or if we should abandon it.

@isuruf or @lazka Would you be willing to check this change for reasonableness? Tests are passing, but I'm a little uneasy to accept it without a second set of eyes...

@sciyoshi Would you be willing to investigate the two failures and suggest a fix?

Thanks! After applying that patch, there's one remaining failure in the pypy tests. ``` if 'LDFLAGS' in os.environ: ldshared = ldshared + ' ' + os.environ['LDFLAGS'] > ldcxxshared = ldcxxshared...

I applied that diff, but unfortunately, that led to more failures in `test_cc_overrides_ldshared_for_cxx_correctly`... and while debugging the issue, I found that test is itself fragile - it fails differently depending...

At main, that test runs fine in isolation. ``` distutils main @ tox -e py311 -q -- -q -p no:cov -k test_cc_overrides_ldshared_for_cxx_correctly . [100%] 1 passed, 477 deselected in 0.18s...

The issue seems to be surfaced by [this change](https://github.com/pypa/distutils/pull/228/commits/ae3afa4401c77920c652a7169ab2fe7db5df5f92#diff-5b14d375bfc18988ec8256ae25616ad57561f507ee3ae79b2818faa342cf5207R254-R256), where the fallback value is now `''`, which allows the darwin-specific behavior to be reached: https://github.com/pypa/distutils/blob/e651e536ef1fbafbe48856815602127df0371835/distutils/sysconfig.py#L285-L291 That code attempts to mutate...