Jason R. Coombs comments

Results 1062 comments of


                                            Jason R. Coombs

Dropping support for Python 2 and Python 3 below 3.5

> > It occurs to me that the changes applied to the head of the repo have not always been stabilizing > > Really? That wasn't my intention at all....

Dropping support for Python 2 and Python 3 below 3.5

Yes. It's time to get this done, even if cheroot is unstable.

Dropping support for Python 2 and Python 3 below 3.5

I've merged the PR to remove Python 3.5 and earlier support and released it as v9.0.0. I don't trust the automated release processes to work, so I just cut the...

Tests in test_session are tightly coupled

I agree - would be good to fix this.

test_tls_client_auth: previous item was not torn down properly

It appears the test that's running before and leaving itself not torn down properly is `test_high_number_of_file_descriptors`. Tests pass if I run: ``` tox -- -k "not test_high_number_of_file_descriptors" ```

test_tls_client_auth: previous item was not torn down properly

Removing the `forked` marker also works around the issue. Skipping the test does not, however.

test_tls_client_auth: previous item was not torn down properly

I can replicate the issue by using this test as the sole "forked" test: ``` @pytest.mark.forked def test_null(): pass ``` So the bug is with forked.

sessions lock race condition deleting expired session

I’d be concerned that swapping out the lock implementation again may or may not address the issue. I’d really like to see a repro that can prove the fix whatever...

Make HTTP server correctly read trailers (Trailer HTTP headers, which come after body)

Here's the test failure: ``` cheroot master $ tox -- --runxfail -k test_Chunked_Encoding python develop-inst-noop: /Users/jaraco/code/public/cherrypy/cheroot python installed: apipkg==1.5,argh==0.26.2,atomicwrites==1.3.0,attrs==19.3.0,certifi==2019.9.11,cffi==1.13.0,chardet==3.0.4,-e git+gh://cherrypy/cheroot@f55e41dd041392ec8504547f18dd5b8e838b5092#egg=cheroot,codecov==2.0.15,colorama==0.4.1,coverage==4.5.3,cryptography==2.8,docopt==0.6.2,execnet==1.7.1,idna==2.8,jaraco.functools==2.0,more-itertools==7.2.0,packaging==19.2,pathtools==0.1.2,pluggy==0.13.0,py==1.8.0,pycparser==2.19,pyOpenSSL==19.0.0,pyparsing==2.4.2,pytest==5.2.1,pytest-cov==2.7.1,pytest-forked==1.1.1,pytest-mock==1.11.1,pytest-sugar==0.9.2,pytest-testmon==0.9.19,pytest-watch==4.2.0,pytest-xdist==1.30.0,PyYAML==5.1.2,requests==2.22.0,requests-unixsocket==0.2.0,six==1.12.0,termcolor==1.1.0,trustme==0.5.2,urllib3==1.25.6,watchdog==0.9.0,wcwidth==0.1.7 python run-test-pre: PYTHONHASHSEED='4070659726' python run-test: commands[0] | pytest --testmon-off --runxfail...

Develop Oauth2 consumer recipe

I believe [the Python Social Auth project](http://python-social-auth.readthedocs.io/en/latest/configuration/cherrypy.html) has also made some headway.