Japin Li

ERROR: data stream ended

1

Recently, I encounter an error abort "data stream ended", I inspect the code and find it happens [here](https://github.com/2ndQuadrant/pglogical/blob/REL2_x_STABLE/pglogical_apply.c#L1373). Here is the error message: ``` 2021-04-29 11:41:56.955 CST,,"xxxxxdb01",183809,,608a2b04.2ce01,1,"",2021-04-29 11:41:56 CST,33/0,0,LOG,00000,"starting apply...

Incorrect documentation about add-instance of remote-options

1

The [documentation](https://postgrespro.github.io/pg_probackup/#pbk-adding-new-backup-instance) says: > If you run this command with the [remote_options](https://postgrespro.github.io/pg_probackup/#pbk-remote-server-opts), the specified parameters will be added to pg_probackup.conf. However, it doesn't write to pg_probackup.conf, and the source code...

I find that [`ColumnarOptions`](https://github.com/citusdata/citus/blob/739c6d26df56d38cda7f5420cccca947874d71e6/src/include/columnar/columnar.h#L67C1-L78C19) declares `stripeRowCount` using `uint64` type, however, the [`STRIPE_ROW_COUNT_MAXIMUM` is defined `10000000`](https://github.com/citusdata/citus/blob/739c6d26df56d38cda7f5420cccca947874d71e6/src/include/columnar/columnar.h#L48C1-L48C42), and the [`FormData_columnar_options`](https://github.com/citusdata/citus/blob/739c6d26df56d38cda7f5420cccca947874d71e6/src/backend/columnar/columnar_metadata.c#L156C1-L172C1) declares `stripe_row_limit` using `int32` type. I'm curious why use `uint64` for `ColumnarOptions.stripeRowCount`?

Inaccurate comments about LookupStorageId()

2

The LookupStorageId() claims `it returns false if the relation doesn't have a meta page yet`. Does it means zero is false here? If so, maybe change it to `it returns...

Parallel compile failed

2

When the postgres comipled using `--with-llvm`, I try to parallelly build pg_probackup, it failed, here is the log: ``` $ pg_config BINDIR = /home/japin/Codes/postgres/build/pg/bin DOCDIR = /home/japin/Codes/postgres/build/pg/share/doc HTMLDIR = /home/japin/Codes/postgres/build/pg/share/doc...

Regression test failed for Toast index test.

1

Hi, When I try to use orioledb on [patches14](https://github.com/orioledb/postgres) on Ubuntu 20.04. I encountered the following errors: ``` PATH="/tmp_install/home/japin/Codes/OrioleDB/build/orioledb/bin:/home/japin/Codes/oriole-extension:$PATH" LD_LIBRARY_PATH="/tmp_install/home/japin/Codes/OrioleDB/build/orioledb/lib:$LD_LIBRARY_PATH" PGCTLTIMEOUT=900 \ python3 -W ignore::DeprecationWarning -m unittest -v t/toast_index_test.py test_checkpoint...

Fix compiler error on Illumos

1

Hi, When I try to use pg_cron on Illumos, there are some errors, such as following: ``` gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing...

Why calculate columnar index scan cost when disabling it?

1

### What's wrong? Hi, When I see the [`CostColumnarIndexPath()`](https://github.com/hydradatabase/hydra/blob/2c2630c48b5c703e8df114dedafdd8c06ab47855/columnar/src/backend/columnar/columnar_customscan.c#L621) code, it seems that the cost of the columnar index scan is calculated when `columnar.enable_columnar_index_scan` is disabled.

Confused about columnar cache regression test

2

### What's wrong? Hi, When I read the regression test in [columnar_cache.sql](https://github.com/hydradatabase/hydra/blob/main/columnar/src/test/regress/sql/columnar_cache.sql), I noticed that it contains the following test case: ```SQL CREATE TABLE big_table ( id INT, firstname TEXT,...

The InsertTupleAndEnforceConstraints() constructed tuple on-the-fly, and on other reference, so we can safely set shouldFree to true for ExecStoreHeapTuple() to avoid duplicate memory allocation. Here is my environment: ```shell $...