Japin Li

Results 20 comments of Japin Li

Hi, @gsmol, I found the documentation do not update, here is a patch to fix the problem. ```diff diff --git a/doc/pgprobackup.xml b/doc/pgprobackup.xml index 2cb10e37..11e49b88 100644 --- a/doc/pgprobackup.xml +++ b/doc/pgprobackup.xml @@...

@onurctirtir Thank you for your explanation. I dig in deeper and find the storage id comes from the first block, which is stored after `PageHeader`, so if this data corrupted,...

@microsoft-github-policy-service agree

@demonolock Thanks for your reply! It seems doesn't work. ``` $ make -j $(nproc) USE_PGXS=1 top_srcdir=/home/japin/Codes/postgres -s PG_CONFIG=/home/japin/Codes/postgres/build/pg/bin/pg_config src/utils/file.c: In function ‘fio_gzread’: src/utils/file.c:1676:43: warning: passing argument 2 of ‘fio_read’ discards...

I find there are two recovery worker always running in `find_page()` loops. ``` top - 17:44:08 up 15 days, 7:12, 1 user, load average: 1.29, 1.98, 2.26 Tasks: 134 total,...

Hi, @marcoslot, For the `__EXTENSIONS__` macro, on illumos, the `sigjmp_buf` is defined under `!defined(_STRICT_STDC) || defined(__XOPEN_OR_POSIX) || defined(__EXTENSIONS__)`, so I enabled this macro on SunOS. See: https://github.com/illumos/illumos-gate/blob/master/usr/src/head/setjmp.h#L50-L58 Now, I only...

@marcoslot Thank you.

Perhaps a demonstration for reproducing the issue would be more helpful.

@mkaruza Thank you for the explanation.

> I am confused as to what you are trying to accomplish here? > > `gettext_noop` is literally a non-operation as it name implies: > > ``` > #define gettext_noop(x)...