Results 20 comments of Jan Hassel

This is great! Just a few things I noticed: 1. Since you'll always need to provide an ID for `aria-labelledby`, there must be no `#` in front of the labelling...

@matthewgallo design review based on PR #2269 deploy preview: | # | Screenshot | Description | | :- | :- | :- | | 1 | ![Screen Recording 2022-09-15 at...

@carmacleod No, Dropdowns shouldn't be used for menus I think. I only brought that up because of the similar interaction (list of clickable elements), maybe that was a bad reference....

@joshblack I quickly tried out some pictograms with the new minimum size of pictograms (48px) and I'm wondering what the reason behind the fractional stroke widths is. With a stroke...

@dudley-ibm Sorry, I was referring to the usage guidelines and how they changed from stating 32px as the minimum size to 48px in July last year (https://github.com/carbon-design-system/carbon-website/pull/1438).

@mjabbink I wasn't suggesting to change the stroke-width from 0.72px to 1px, but referring to the calculated stroke-width of pictograms at a 48px size, which is currently 1.08px (0.72px at...

@mjabbink Let me carefully ask the following while hoping to not making @dudley-ibm explore already. 😄 Is there are reason to design the pictograms on a 32x32px original size since...

@mjabbink @dudley-ibm I agree that the filled shapes like circles mostly likely don't need to change. Regarding the original artwork size: To achieve the perfect sharpness on 48px, the pictograms...

@mjabbink Sounds reasonable! Maybe the redraw could also be a longer, staggered process. So updating some pictograms already to 48x48 for their source while others remain at 32x32 and pushing...

> Me saying this makes me wonder if we should change the guidance to 64px minimum size. I think this would make a lot of sense actually and further differentiates...